Re: [PATCH -v1 00/13] sched/balancing: Standardize the naming of scheduler load-balancing functions

From: Ingo Molnar
Date: Fri Mar 08 2024 - 06:26:07 EST



* Ingo Molnar <mingo@xxxxxxxxxx> wrote:

> Over the years we've grown a colorful zoo of scheduler
> load-balancing function names - both following random,
> idiosyncratic patterns, and gaining historic misnomers
> that are not accurate anymore.
>
> We have 'newidle_balance()' to rebalance newly idle tasks,
> but 'balance_domains()' to rebalance domains. We have
> a find_idlest_cpu() function whose purpose is not to find
> the idlest CPU anymore, and a find_busiest_queue() function
> whose purpose is not to find the busiest runqueue anymore.
>
> Fix most of the misnomers and organize the functions along the
> sched_balance_*() namespace:
>
> scheduler_tick() => sched_tick()
> run_rebalance_domains() => sched_balance_softirq()
> trigger_load_balance() => sched_balance_trigger()
> rebalance_domains() => sched_balance_domains()
> load_balance() => sched_balance_rq()
> newidle_balance() => sched_balance_newidle()
> find_busiest_queue() => sched_balance_find_src_rq()
> find_busiest_group() => sched_balance_find_src_group()
> find_idlest_group_cpu() => sched_balance_find_dst_group_cpu()
> find_idlest_group() => sched_balance_find_dst_group()
> find_idlest_cpu() => sched_balance_find_dst_cpu()
> update_blocked_averages() => sched_balance_update_blocked_averages()

Forgot to mention that this series is on top of the scheduler tree
(tip:sched/core) plus my other pending queue:

https://lore.kernel.org/r/20240308105901.1096078-1-mingo@xxxxxxxxxx

Thanks,

Ingo