Re: [PATCH 1/2] arm64: dts: rockchip: enable internal pull-up for Q7_THRM# on RK3399 Puma

[Quentin Schulz]

Hi Heiko,

On 3/8/24 10:29, Heiko Stübner wrote:
> Am Freitag, 8. März 2024, 10:25:43 CET schrieb Quentin Schulz:
> > Hi Iskander,
> >
> > On 3/8/24 09:52, Iskander Amara wrote:
> > > Q7_THRM# pin is connected to a diode on the module which is used
> > > as a level shifter, and the pin have a pull-down enabled by
> > > default. We need to configure it to internal pull-up, other-
> > > wise whenever the pin is configured as INPUT and we try to
> > > control it externally the value will always remain zero.
> > >
> > > Signed-off-by: Iskander Amara <iskander.amara@xxxxxxxxxxxxxxxxxxxxx>
> >
> > For the whole series:
> >
> > Reviewed-by: Quentin Schulz <quentin.schulz@xxxxxxxxxxxxxxxxxxxxx>
> >
> > @Heiko I think this may match the criteria for stable backports?
>
> at least patch1 does ... it definitly should have a Fixes tag though.

Fixes: 2c66fc34e945 ("arm64: dts: rockchip: add RK3399-Q7 (Puma) SoM")

I assume, since this issue existed since the introducing commit.

Cheers,
Quentin