Re: [PATCH v2 2/2] media: i2c: Add imx283 camera sensor driver

[Andy Shevchenko]

On Fri, Mar 8, 2024 at 1:11 AM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> On Thu, Mar 7, 2024 at 11:41 PM Umang Jain <umang.jain@xxxxxxxxxxxxxxxx> wrote:
> >
> > From: Kieran Bingham <kieran.bingham@xxxxxxxxxxxxxxxx>
> >
> > Add a v4l2 subdevice driver for the Sony IMX283 image sensor.
> >
> > The IMX283 is a 20MP Diagonal 15.86 mm (Type 1) CMOS Image Sensor with
> > Square Pixel for Color Cameras.
> >
> > The following features are supported:
> > - Manual exposure an gain control support

and

> > - vblank/hblank/link freq control support
> > - Test pattern support control
> > - Arbitrary horizontal and vertical cropping
> > - Supported resolution:
> >   - 5472x3648 @ 20fps (SRGGB12)
> >   - 5472x3648 @ 25fps (SRGGB10)
> >   - 2736x1824 @ 50fps (SRGGB12)

..

> + array_size.h
> + bitops.h
> + container_of.h
>
> > +#include <linux/clk.h>
> > +#include <linux/delay.h>
>
> + errno.h

Actually err.h.

> > +#include <linux/gpio/consumer.h>
> > +#include <linux/i2c.h>

And
+ minmax.h

> > +#include <linux/module.h>
>
> + mutex.h
>
> > +#include <linux/of.h>
>
> How is this being used, please?
>
> > +#include <linux/pm_runtime.h>
>
> + property.h
>
> > +#include <linux/regulator/consumer.h>
>
> + types.h
>
> > +#include <linux/units.h>


-- 
With Best Regards,
Andy Shevchenko