Re: [PATCH v3 04/11] i2c: nomadik: use bitops helpers

[Andi Shyti]

Hi Theo,

On Wed, Mar 06, 2024 at 06:59:24PM +0100, Théo Lebrun wrote:
> Constant register bit fields are declared using hardcoded hex values;
> replace them by calls to BIT() and GENMASK(). Replace custom GEN_MASK()
> macro by the generic FIELD_PREP(). Replace manual bit manipulations by
> the generic FIELD_GET() macro.
> 
> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Signed-off-by: Théo Lebrun <theo.lebrun@xxxxxxxxxxx>

Thanks!

Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxx>

Andi