Re: [PATCH v3 03/11] i2c: nomadik: simplify IRQ masking logic

[Andi Shyti]

Hi Theo,

On Wed, Mar 06, 2024 at 06:59:23PM +0100, Théo Lebrun wrote:
> IRQ_MASK and I2C_CLEAR_ALL_INTS both mask available interrupts. IRQ_MASK
> removes top options (bits 29-31). I2C_CLEAR_ALL_INTS removes reserved
> options including top bits. Keep the latter.
> 
> 31  29  27  25  23  21  19  17  15  13  11  09  07  05  03  01
>   30  28  26  24  22  20  18  16  14  12  10  08  06  04  02  00
> --- IRQ_MASK: --------------------------------------------------
>       1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1
> 0 0 0
> --- I2C_CLEAR_ALL_INTS: ----------------------------------------
>       1     1 1       1 1 1 1 1                   1 1 1 1 1 1 1
> 0 0 0   0 0     0 0 0           0 0 0 0 0 0 0 0 0
> 
> Notice I2C_CLEAR_ALL_INTS is more restrictive than IRQ_MASK.
> 
> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Signed-off-by: Théo Lebrun <theo.lebrun@xxxxxxxxxxx>

You did answer my question in v2, thanks, Theo!

Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxx>

Andi