Re: [PATCH] tg3: Remove residual error handling in tg3_suspend

[Michael Chan]

On Thu, Mar 7, 2024 at 11:23 AM Nikita Kiryushin <kiryushin@xxxxxxxx> wrote:
>
>
> As of now, tg3_power_down_prepare always ends with success, but
> the error handling code from former tg3_set_power_state call is still here.
>
> Remove (now unreachable) code for simplification.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: c866b7eac073 ("tg3: Do not use legacy PCI power management")
> Signed-off-by: Nikita Kiryushin <kiryushin@xxxxxxxx>

The patch looks good to me.  But I think we can go one step further
and change tg3_power_down_prepare() to a void function.  Thanks.

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature