Re: [PATCH 1/2] mm/huge_memory: check new folio order when split a folio

[Zi Yan]

On 7 Mar 2024, at 15:02, Andrew Morton wrote:

> On Thu,  7 Mar 2024 13:18:53 -0500 Zi Yan <zi.yan@xxxxxxxx> wrote:
>
>> From: Zi Yan <ziy@xxxxxxxxxx>
>>
>> A folio can only be split into lower orders. Check new_order to make sure
>> it is smaller than input folio order.
>
> It isn't clear what's being fixed here.  Presumably something is
> passing in such folios, but what and where and why and what are the
> effects?
>
> Might it be that these folios are being caused by the debugfs
> interface?  Or something else?

Since there is no new_order checks in debugfs before, any
new_order can be passed via debugfs into
split_huge_page_to_list_to_order().

I did not explicitly mention it here as the debugfs is added in
the commit after the Fixes one.

>
> So I'll add it, but I do think more information and context would
> improve the patch, please.  Suitable Reported-by:, Closes: and Link:
> tags, perhaps.


--
Best Regards,
Yan, Zi

Attachment: signature.asc
Description: OpenPGP digital signature