Re: [PATCH v4 2/4] dt-bindings: media: add Maxim MAX96714 GMSL2 Deserializer

[Conor Dooley]

On Tue, Mar 05, 2024 at 04:26:06PM +0100, Julien Massot wrote:
> Add DT bindings for Maxim MAX96714 GMSL2 Deserializer.
> 
> Signed-off-by: Julien Massot <julien.massot@xxxxxxxxxxxxx>
> ---
> Change since v3:
>  - Renamed file to maxim,max96714.yaml dropped the 'f' suffix

Why? The filename should match the compatible, which /does/ have an f.

>  - Removed mention to C-PHY since it's not supported by MAX96714 deserializers
>  - Removed bus-type requirement on CSI endpoint since the device only support D-PHY
>  - Removed the clock-lanes property in the dt example
> 
> Change since v2:
>  - remove reg description
>  - rename enable gpio to powerdown
>  - use generic node name: i2c, serializer, deserializer
> ---
> ---
>  .../bindings/media/i2c/maxim,max96714.yaml    | 169 ++++++++++++++++++
>  1 file changed, 169 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/i2c/maxim,max96714.yaml

> +properties:
> +  compatible:
> +    const: maxim,max96714f

> +  i2c-gate:
> +    $ref: /schemas/i2c/i2c-controller.yaml

There is an i2c-gate binding, you should reference it here instead.

> +    unevaluatedProperties: false
> +    description: |

This | is not needed, there's no formatting to preserve.

> +      The MAX96714 will pass through and forward the I2C requests from the
> +      incoming I2C bus over the GMSL2 link. Therefore it supports an i2c-gate
> +      subnode to configure a serializer.

Attachment: signature.asc
Description: PGP signature