Re: [PATCH v1 1/2] spi: pxa2xx: Kill pxa2xx_set_spi_info()

From: Arnd Bergmann
Date: Thu Mar 07 2024 - 11:48:29 EST


On Thu, Mar 7, 2024, at 17:42, Andy Shevchenko wrote:
> On Thu, Mar 07, 2024 at 05:30:10PM +0100, Arnd Bergmann wrote:
>> On Thu, Mar 7, 2024, at 17:07, Andy Shevchenko wrote:
>> > spi_register_board_info(ARRAY_AND_SIZE(spitz_spi_devices));
>>
>> I think the normal interface these days would be
>> platform_device_register_data(), which does it all in one step.
>
> I'm not sure how is this related to the SPI board info registration.

It's not. What I meant is that you could use
platform_device_register_data() instead of the
"platform_device_alloc(); platform_data = info; platform_device_add();"
sequence.

It should be a safe conversion, but it's also fine to stay
with the existing version if you are worried about regressions.

Arnd