Re: [PATCH] pinctrl: aw9523: allow building as loadable module

[Linus Walleij]

On Thu, Mar 7, 2024 at 3:07 PM Arnd Bergmann <arnd@xxxxxxxxxx> wrote:


> When CONFIG_I2C is set to =m, the new aw9523 driver fails to link:
>
> arm-linux-gnueabi-ld: drivers/pinctrl/pinctrl-aw9523.o: in function `aw9523_probe':
> pinctrl-aw9523.c:(.text+0x9f8): undefined reference to `__devm_regmap_init_i2c'
> arm-linux-gnueabi-ld: drivers/pinctrl/pinctrl-aw9523.o: in function `aw9523_driver_init':
> pinctrl-aw9523.c:(.init.text+0x4): undefined reference to `i2c_register_driver'
> arm-linux-gnueabi-ld: drivers/pinctrl/pinctrl-aw9523.o: in function `aw9523_driver_exit':
> pinctrl-aw9523.c:(.exit.text+0x2): undefined reference to `i2c_del_driver'
>
> Make it a tristate symbol so the dependency is correctly honored.
>
> Fixes: bfa5aa367a82 ("pinctrl: Add driver for Awinic AW9523/B I2C GPIO Expander")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

I sent something similar yesterday:
https://lore.kernel.org/linux-gpio/20240305-fix-aw9523-v2-1-2dc50bab2b17@xxxxxxxxxx/

Thanks anyway!

Yours,
Linus Walleij