Re: [PATCH v3] powerpc: macio: Make remove callback of macio driver void returned

From: Michael Ellerman
Date: Thu Mar 07 2024 - 07:32:36 EST


Dawei Li <set_pte_at@xxxxxxxxxxx> writes:
> Hi Christophe,
>
> On Tue, Feb 20, 2024 at 04:12:17PM +0000, Christophe Leroy wrote:
>> Hi Michael,
>>
>> ping ?
>>
>> Le 01/02/2023 à 15:36, Dawei Li a écrit :
>> > Commit fc7a6209d571 ("bus: Make remove callback return void") forces
>> > bus_type::remove be void-returned, it doesn't make much sense for any
>> > bus based driver implementing remove callbalk to return non-void to
>> > its caller.
>> >
>> > This change is for macio bus based drivers.
>> >
>> > Signed-off-by: Dawei Li <set_pte_at@xxxxxxxxxxx>
>>
>> This patch is Acked , any special reason for not applying it ?
>>
>> Note that it now conflicts with commit 1535d5962d79 ("wifi: remove
>> orphaned orinoco driver") but resolution is trivial, just drop the
>> changes to that file.
>
> Thanks for picking it up, hardly believe that it's been one year.
>
> Michael,
>
> I will respin V4 if it's needed.

No that's fine, I'll sort it out.

cheers