Re: [PATCH] mmc: dw_mmc: remove unneeded assignment

[Yang Xiwen]

On 3/7/2024 8:21 PM, Muhammad Usama Anjum wrote:
> The err is being set to 0 and replaced every time after this
> assignment. Remove this assignment as it is extraneous.
>
> Fixes: 25d043841db1 ("mmc: dw_mmc: add support for hi3798mv200")
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@xxxxxxxxxxxxx>
> ---
>   drivers/mmc/host/dw_mmc-hi3798mv200.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-hi3798mv200.c b/drivers/mmc/host/dw_mmc-hi3798mv200.c
> index 989ae8dda7228..96af693e3e37c 100644
> --- a/drivers/mmc/host/dw_mmc-hi3798mv200.c
> +++ b/drivers/mmc/host/dw_mmc-hi3798mv200.c
> @@ -133,7 +133,6 @@ static int dw_mci_hi3798mv200_execute_tuning_mix_mode(struct dw_mci_slot *slot,
>   			goto tuning_out;
>   
>   		prev_err = err;
> -		err = 0;


Same for dw_mmc-hi3798cv200.c, maybe fix it as well?


>   	}
>   
>   tuning_out:


--
Regards,
Yang Xiwen