Re: [EXTERNAL] Re: [PATCH v10] The tas2783 is a smart audio amplifier with integrated MIPI SoundWire interface (Version 1.2.1 compliant), I2C, and I2S/TDM interfaces designed for portable applications. An on-chip DSP supports Texas Instruments SmartAmp sp

From: Mark Brown
Date: Thu Mar 07 2024 - 06:42:18 EST


On Thu, Mar 07, 2024 at 03:56:40AM +0000, Ding, Shenghao wrote:

> > We also try to keep default settings from the silicon except in the most
> > obvious cases, it avoids issues with trying to work out what to set and
> > accomodate different use cases for different systems.

> > If you do need to set non-default values then either just regular writes during
> > probe or a regmap patch would do it.

> So, can I remove
> ".reg_defaults = tas2783_reg_defaults," and tas2783_reg_defaults from the code?

Yes, supplying register defaults is completely optional. It means we
can't omit default values from cache sync and have to read values back
from the device the first time we read but those tend to be fairly minor
performance impacts.

Attachment: signature.asc
Description: PGP signature