Re: [PATCH net-next v3 10/12] net: ethernet: oa_tc6: implement mac-phy interrupt

From: Parthiban.Veerasooran
Date: Thu Mar 07 2024 - 05:16:48 EST


Hi Woojung,

On 07/03/24 5:12 am, Woojung Huh - C21699 wrote:
> Hi Parthiban,
>
> ...
>
>> +static irqreturn_t oa_tc6_macphy_isr(int irq, void *data)
>> +{
>> + struct oa_tc6 *tc6 = data;
>> +
>> + /* MAC-PHY interrupt can occur for the following reasons.
>> + * - availability of tx credits if it was 0 before and not reported
>> in
>> + * the previous rx footer.
>
> Per description above, it may be typo of "the previous rx footer"
Sorry, I don't get your comment. Could you please elaborate?

Best regards,
Parthiban V
>
>> + * - availability of rx chunks if it was 0 before and not reported
>> in
>> + * the previous rx footer.
>> + * - extended status event not reported in the previous rx footer.
>> + */
>> + tc6->int_flag = true;
>> + /* Wake spi kthread to perform spi transfer */
>> + wake_up_interruptible(&tc6->spi_wq);
>> +
>> + return IRQ_HANDLED;
>> +}
>> +
>