Re: [PATCH v3] dt-bindings: hwmon: tda38640: Add interrupt & regulator properties

From: Naresh Solanki
Date: Thu Mar 07 2024 - 05:13:44 EST


Hi,


On Thu, 7 Mar 2024 at 00:08, Conor Dooley <conor@xxxxxxxxxx> wrote:
>
> On Wed, Mar 06, 2024 at 03:20:02PM +0530, Naresh Solanki wrote:
> > Hi Krzysztof,
> >
> >
> > On Wed, 6 Mar 2024 at 12:44, Krzysztof Kozlowski
> > <krzysztof.kozlowski@xxxxxxxxxx> wrote:
> > >
> > > On 05/03/2024 22:07, Naresh Solanki wrote:
> > > > Add properties for interrupt & regulator.
> > > > Also update example.
> > >
> > > Nothing improved.
> > Yes, Just aligned the regulator node name in this revision.
> > I missed aligning the commit message.
> >
> > I'll fix in next revision & update commit message as:
> >
> > tda38640 has a single regulator output along with
> > CAT_FAULT# pin to report internal events.
> > Hence add properties for regulator & interrupt.
> >
> > Let me know if any others changes needed.
>
> That should be fine - but your line wrapping is really odd, you can make
> use of 72 characters but you are wrapping at ~50.
Sure. Will push another revision with the changes.

Thanks & Regards,
Naresh