RE: [PATCH 2/7] vfio/pci: Lock external INTx masking ops

[Tian, Kevin]

> From: Alex Williamson <alex.williamson@xxxxxxxxxx>
> Sent: Thursday, March 7, 2024 5:15 AM
> 
> Mask operations through config space changes to DisINTx may race INTx
> configuration changes via ioctl.  Create wrappers that add locking for
> paths outside of the core interrupt code.
> 
> In particular, irq_type is updated holding igate, therefore testing
> is_intx() requires holding igate.  For example clearing DisINTx from
> config space can otherwise race changes of the interrupt configuration.
> 

Looks the suspend path still checks irq_type w/o holding igate:

	vdev->pm_intx_masked = ((vdev->irq_type == VFIO_PCI_INTX_IRQ_INDEX) &&
				 vfio_pci_intx_mask(vdev));

Is it with assumption that no change of configuration is possible at
that point?