Re: [PATCH] arm64: dts: qcom: sm8150: add reset name for ethernet node

[Krzysztof Kozlowski]

On 07/03/2024 08:10, Dmitry Baryshkov wrote:
> On Thu, 7 Mar 2024 at 00:22, Volodymyr Babchuk
> <Volodymyr_Babchuk@xxxxxxxx> wrote:
>>
>> Add reset-names property to the ethernet@20000 node. This patch does
>> not change behavior on Linux, but it is needed for U-Boot, as it tries
>> to find the reset by name, not by index.
>>
>> Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
>> ---
>>  arch/arm64/boot/dts/qcom/sm8150.dtsi | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
>> index 761a6757dc26f..c2e65d6a2ac62 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
>> @@ -951,6 +951,7 @@ ethernet: ethernet@20000 {
>>
>>                         power-domains = <&gcc EMAC_GDSC>;
>>                         resets = <&gcc GCC_EMAC_BCR>;
>> +                       resets-names = "emac";
> 
> According to the snps,dwmac.yaml schema the "emac" is invalid here.
> Only "stmmaceth" and / or "ahb" are permitted here.

If only there was a tool which can tell this, without the need to
involve reviewers...

Best regards,
Krzysztof