Re: [PATCH v2] overflow: Change DEFINE_FLEX to take __counted_by member

From: Przemek Kitszel
Date: Thu Mar 07 2024 - 02:32:28 EST


On 3/7/24 00:51, Kees Cook wrote:
The norm should be flexible array structures with __counted_by
annotations, so DEFINE_FLEX() is updated to expect that. Rename
the non-annotated version to DEFINE_RAW_FLEX(), and update the
few existing users.

Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
---
Cc: Przemek Kitszel <przemyslaw.kitszel@xxxxxxxxx>
Cc: Jesse Brandeburg <jesse.brandeburg@xxxxxxxxx>
Cc: Tony Nguyen <anthony.l.nguyen@xxxxxxxxx>
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
Cc: Eric Dumazet <edumazet@xxxxxxxxxx>
Cc: Jakub Kicinski <kuba@xxxxxxxxxx>
Cc: Paolo Abeni <pabeni@xxxxxxxxxx>
Cc: "Gustavo A. R. Silva" <gustavoars@xxxxxxxxxx>
Cc: intel-wired-lan@xxxxxxxxxxxxxxxx
Cc: netdev@xxxxxxxxxxxxxxx
Cc: linux-hardening@xxxxxxxxxxxxxxx
v2: swap member/counter args
v1: https://lore.kernel.org/lkml/20240306010746.work.678-kees@xxxxxxxxxx/
---
drivers/net/ethernet/intel/ice/ice_common.c | 4 +--
drivers/net/ethernet/intel/ice/ice_ddp.c | 8 +++---
drivers/net/ethernet/intel/ice/ice_lag.c | 6 ++---
drivers/net/ethernet/intel/ice/ice_lib.c | 4 +--
drivers/net/ethernet/intel/ice/ice_sched.c | 4 +--
drivers/net/ethernet/intel/ice/ice_switch.c | 10 ++++----
drivers/net/ethernet/intel/ice/ice_xsk.c | 2 +-
include/linux/overflow.h | 27 +++++++++++++++++----
lib/overflow_kunit.c | 19 +++++++++++++++
9 files changed, 60 insertions(+), 24 deletions(-)


Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@xxxxxxxxx>