Re: [PATCH v5 1/3] sched/fair: Add EAS checks before updating overutilized

[Shrikanth Hegde]

On 3/6/24 11:10 PM, Vincent Guittot wrote:
> On Wed, 6 Mar 2024 at 11:25, Shrikanth Hegde <sshegde@xxxxxxxxxxxxx> wrote:
>>  #else
>> -static inline void update_overutilized_status(struct rq *rq) { }
>> +static inline void check_update_overutilized_status(struct rq *rq)
>> +{
>> +       return 0;
>> +}
> 
> static inline void check_update_overutilized_status(struct rq *rq) { }
> 

Yes. Thanks for catching. I made a mistake there. 

>> +
>> +static inline void set_rd_overutilized_status(struct root_domain *rd,
>> +                                             unsigned int status)
>> +{
>> +       return 0;
>> +}
> 
> static inline void set_rd_overutilized_status(struct rq *rq) { }
> 
> my comment on v4 about {return 0; } applies only for static inline int
> is_rd_overutilized(struct root_domain *rd)
> 
> Also, I don't think that set_rd_overutilized_status() is called
> outside #ifdef CONFIG_SMP so you can remove it.
> 

yes. this set_rd_overutilized_status and is_rd_overutilized or is_rd_not_overutilized
can go away for !CONFIG_SMP case. Let me do that and send next version. 

> 
> 
>