回复: [PATCH v1 1/7] staging: media: starfive: Replaced current_fmt with get from sd_state

[Changhuang Liang]

Hi, Dan

Thanks for your comments.

> -----邮件原件-----
> 发件人: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> 发送时间: 2024年3月6日 22:23
> 收件人: Changhuang Liang <changhuang.liang@xxxxxxxxxxxxxxxx>
> 抄送: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>; Greg Kroah-Hartman
> <gregkh@xxxxxxxxxxxxxxxxxxx>; Hans Verkuil <hverkuil-cisco@xxxxxxxxx>;
> Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>; Jack Zhu
> <jack.zhu@xxxxxxxxxxxxxxxx>; linux-media@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; linux-staging@xxxxxxxxxxxxxxx
> 主题: Re: [PATCH v1 1/7] staging: media: starfive: Replaced current_fmt with
> get from sd_state
> 
> On Wed, Mar 06, 2024 at 01:33:28AM -0800, Changhuang Liang wrote:
> > current_fmt only can store one pad format, when setting other pad it
> > will be overwrote. Replaced it with get from sd_state directly.
> >
> 
> These commit descriptions are kind of hard to understand so I have proposed
> new commit messages.
> 
> Subject: staging: media: starfive: Get rid of current_fmt
> 
> We want to support mutiple formats so saving one "current_fmt" doesn't
> work.  This was only used to set the ISP_REG_STRIDE so use the sd_state
> directly for that and delete the ->current_fmt pointer.  No functional change.
> 

I will re-change the patch description and add more details to all the patches.

Thanks