Re: [PATCH 13/16] KVM: x86/mmu: Handle no-slot faults at the beginning of kvm_faultin_pfn()

[Sean Christopherson]

On Thu, Mar 07, 2024, Kai Huang wrote:
> 
> 
> On 28/02/2024 3:41 pm, Sean Christopherson wrote:
> > --- a/arch/x86/kvm/mmu/mmu_internal.h
> > +++ b/arch/x86/kvm/mmu/mmu_internal.h
> > @@ -235,7 +235,7 @@ struct kvm_page_fault {
> >   	/* The memslot containing gfn. May be NULL. */
> >   	struct kvm_memory_slot *slot;
> > -	/* Outputs of kvm_faultin_pfn.  */
> > +	/* Outputs of kvm_faultin_pfn. */
> >   	unsigned long mmu_seq;
> >   	kvm_pfn_t pfn;
> >   	hva_t hva;
> 
> ... how about get rid of this non-related fix?

Eww, yeah, I'll drop it.  I originally had code that made the outputs valid if
and only if @slot was non-null, and had updated the comment accordingly, but
ended up going a different route and cleaned up the comment a little too well :-)