Re: [PATCH] netdev: Use flexible array for trailing private bytes

From: Kees Cook
Date: Wed Mar 06 2024 - 18:44:01 EST


On Wed, Mar 06, 2024 at 07:06:58AM -0800, Jakub Kicinski wrote:
> On Wed, 6 Mar 2024 05:16:16 -0800 Breno Leitao wrote:
> > I've been looking at some of these embedders as reported by Kees[1], and
> > most of them are for dummy interfaces. I.e, they are basically used for
> > schedule NAPI poll.
> >
> > From that list[1], most of the driver matches with:
> >
> > # git grep init_dummy_netdev
> >
> > That said, do you think it is still worth cleaning up embedders for
> > dummy net_devices?
> >
> > [1] https://lore.kernel.org/all/202402281554.C1CEEF744@keescook/
>
> Yes, I think so.
> Kees, did you plan to send a v2? Otherwise I can put the cleanup on our
> "public ToDo" list :)

I found the requested collateral changes that popped out of v1 to be
rather a bit much for me to tackle right now, so I think adding to the
TODO list is probably best. :)

-Kees

--
Kees Cook