Re: [PATCH net 3/3] net: lan743x: Address problems with wake option flags configuration sequences

From: Andrew Lunn
Date: Wed Mar 06 2024 - 18:19:16 EST


> I'm not able to find any more "ethtool" documentations other than ethtool man page.
>
> I have gone through the ethtool application code.
> (git://git.kernel.org/pub/scm/network/ethtool/ethtool.git) and check the WOL options.
>
> In ioctl method (Not netlink), do_sset( ) function, before set the parameters, first get the WOL configuration.
> (i.e. in ethtool.c file, Line no. 3294)
>
> Then, assign/overwrite WOL wanted config to wolopts parameter.

Thanks for documenting all this. So it does seem like wol options
overwrite, rather than add incrementally. So i would say the correct
'fix' here is to document that in the man page, because at the moment
it is not clear what should happen.

Now i need to go back and look at what your original issue was...

Andrew