Re: [PATCH net-next] net: phy: dp8382x: keep WOL setting across suspends

[Andrew Lunn]

On Wed, Mar 06, 2024 at 06:14:46PM +0100, Catalin Popescu wrote:
> Unlike other ethernet PHYs from TI, PHY dp83822x has WOL enabled
> at reset.

This is rather odd behaviour. Is this stated in the datasheet?

> @@ -572,11 +584,17 @@ static int dp83826_config_init(struct phy_device *phydev)
>  			return ret;
>  	}
>  
> +	if (dp83822->wol_enabled)
> +		return 0;
>  	return dp8382x_disable_wol(phydev);
>  }
>  
>  static int dp8382x_config_init(struct phy_device *phydev)
>  {
> +	struct dp83822_private *dp83822 = phydev->priv;
> +
> +	if (dp83822->wol_enabled)
> +		return 0;
>  	return dp8382x_disable_wol(phydev);

Since it is rather odd behaviour, there might be some BIOSes which
disable WoL. So i would not rely on it being enabled by
default. Explicitly enable it.

    Andrew

---
pw-bot: cr