Re: [PATCH] thermal: core: remove unnecessary check in trip_point_hyst_store()

From: Rafael J. Wysocki
Date: Wed Mar 06 2024 - 07:27:44 EST


On Wed, Mar 6, 2024 at 6:31 AM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>
> This code was shuffled around a bit recently. We no longer need to
> check the value of "ret" because we know it's zero.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> drivers/thermal/thermal_sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/thermal_sysfs.c b/drivers/thermal/thermal_sysfs.c
> index 7c02d35384ce..5b533fa40437 100644
> --- a/drivers/thermal/thermal_sysfs.c
> +++ b/drivers/thermal/thermal_sysfs.c
> @@ -181,7 +181,7 @@ trip_point_hyst_store(struct device *dev, struct device_attribute *attr,
>
> mutex_unlock(&tz->lock);
>
> - return ret ? ret : count;
> + return count;
> }
>
> static ssize_t
> --

Good catch, applied.

Thanks!