Re: [PATCH v7 4/7] scsi: mvsas: Add libsas SATA sysfs attributes group

[Niklas Cassel]

On Tue, Mar 05, 2024 at 05:22:23PM -0800, Igor Pylypiv wrote:
> The added sysfs attributes group enables the configuration of NCQ Priority
> feature for HBAs that rely on libsas to manage SATA devices.
> 
> Reviewed-by: John Garry <john.g.garry@xxxxxxxxxx>
> Reviewed-by: Damien Le Moal <dlemoal@xxxxxxxxxx>
> Reviewed-by: Jason Yan <yanaijie@xxxxxxxxxx>
> Signed-off-by: Igor Pylypiv <ipylypiv@xxxxxxxxxx>
> ---
>  drivers/scsi/mvsas/mv_init.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/scsi/mvsas/mv_init.c b/drivers/scsi/mvsas/mv_init.c
> index 43ebb331e216..f1090bb5f2c9 100644
> --- a/drivers/scsi/mvsas/mv_init.c
> +++ b/drivers/scsi/mvsas/mv_init.c
> @@ -26,6 +26,7 @@ static const struct mvs_chip_info mvs_chips[] = {
>  };
>  
>  static const struct attribute_group *mvst_host_groups[];
> +static const struct attribute_group *mvst_sdev_groups[];

I think you can remove this line.


>  
>  #define SOC_SAS_NUM 2
>  
> @@ -53,6 +54,7 @@ static const struct scsi_host_template mvs_sht = {
>  	.compat_ioctl		= sas_ioctl,
>  #endif
>  	.shost_groups		= mvst_host_groups,
> +	.sdev_groups		= mvst_sdev_groups,
>  	.track_queue_depth	= 1,
>  };
>  
> @@ -779,6 +781,11 @@ static struct attribute *mvst_host_attrs[] = {
>  
>  ATTRIBUTE_GROUPS(mvst_host);
>  
> +static const struct attribute_group *mvst_sdev_groups[] = {
> +	&sas_ata_sdev_attr_group,
> +	NULL
> +};

.and move these lines up to be after:
static const struct attribute_group *mvst_host_groups[];


> +
>  module_init(mvs_init);
>  module_exit(mvs_exit);
>  
> -- 
> 2.44.0.278.ge034bb2e1d-goog
>