Re: [PATCH v3 2/2] nvme-rdma: short-circuit reconnect retries

From: Chaitanya Kulkarni
Date: Wed Mar 06 2024 - 03:12:59 EST


On 3/5/24 00:00, Daniel Wagner wrote:
> From: Hannes Reinecke <hare@xxxxxxx>
>
> Returning an nvme status from nvme_rdma_setup_ctrl() indicates
> that the association was established and we have received a status
> from the controller; consequently we should honour the DNR bit.
> If not any future reconnect attempts will just return the same error, so
> we can short-circuit the reconnect attempts and fail the connection
> directly.
>
> Signed-off-by: Hannes Reinecke <hare@xxxxxxx>
> Signed-off-by: Daniel Wagner <dwagner@xxxxxxx>
> ---
>

same here, do we need a same fix for FC as well ? just curious ...

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@xxxxxxxxxx>

-ck