Re: [PATCH] USB: serial: option: add Fibocom FM135-GL variants

From: Lars Melin
Date: Wed Mar 06 2024 - 01:40:16 EST


On 2024-03-06 13:18, Bolan Wang(Bolan) wrote:
If the device with pid 0x01a1 only has an mbim interface as you have indicated then why do you add it to the option serial driver?

Hi Lars:
The pid 0x01a1 may include at, diag ports in different usb modes. Currently, only has the mbim interface.

thanks
bolan

Hi Bolan,
so you already know that other versions of the card will have the pid 0x01a1 and the serial interfaces will be of class ff but you don't
know what those interfaces will be used for?
You shall only add driver support for what you know today and not for something that might or might not be implemented in the future.

For the device with pid 0x0115 you have listed an adb interface and adb interfaces should not be in the option driver.

thanks
Lars