Re: [PATCH v2 0/7] scsi: replace deprecated strncpy

[Justin Stitt]

On Wed, Feb 28, 2024 at 4:18 PM Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>
> On Wed, Feb 28, 2024 at 10:59:00PM +0000, Justin Stitt wrote:
> > This series contains multiple replacements of strncpy throughout the
> > scsi subsystem.
> >
> > strncpy() is deprecated for use on NUL-terminated destination strings
> > [1] and as such we should prefer more robust and less ambiguous string
> > interfaces. The details of each replacement will be in their respective
> > patch.
> >
> > ---
> > Changes in v2:
> > - for (1/7): change strscpy to simple const char* assignments
> > - Link to v1: https://lore.kernel.org/r/20240223-strncpy-drivers-scsi-mpi3mr-mpi3mr_fw-c-v1-0-9cd3882f0700@xxxxxxxxxx
>
> I think you lost my tags for the later patches. I re-reviewed a few and
> then remembered I'd already reviewed these and they were unchanged. :)
>
> Please run:
>
> b4 trailers -u 20240223-strncpy-drivers-scsi-mpi3mr-mpi3mr_fw-c-v1-0-9cd3882f0700@xxxxxxxxxx

Gotcha, I've resent [1]

I've also added this into my scripting so I shouldn't miss any future
trailers from vN to vN+1. :)

>
> :)
>
> -Kees
>
> --
> Kees Cook

[1]: https://lore.kernel.org/r/20240305-strncpy-drivers-scsi-mpi3mr-mpi3mr_fw-c-v3-0-5b78a13ff984@xxxxxxxxxx