Re: [PATCH] pinctrl: pinmux: Suppress error message for -EPROBE_DEFER

From: Linus Walleij
Date: Tue Mar 05 2024 - 17:30:23 EST


On Tue, Mar 5, 2024 at 3:39 PM Andre Przywara <andre.przywara@xxxxxxx> wrote:

> EPROBE_DEFER error returns are not really critical, since they cancel
> the probe process, but the kernel will return later and retry.
> However, depending on the probe order, this might issue quite some
> verbatim and scary, though pointless messages:
>
> [ 2.388731] 300b000.pinctrl: pin-224 (5000000.serial) status -517
> [ 2.397321] 300b000.pinctrl: could not request pin 224 (PH0) from group PH0 on device 300b000.pinctrl
>
> Replace dev_err() with dev_err_probe(), which not only drops the
> priority of the message from error to debug, but also puts some text
> into debugfs' devices_deferred file, for later reference.
>
> Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx>

That does cut a lot of noise.

Patch applied!

Yours,
Linus Walleij