Re: [PATCH v1 2/2] platform/x86: intel_scu_pcidrv: Remove unused intel-mid.h

From: Kuppuswamy Sathyanarayanan
Date: Tue Mar 05 2024 - 14:40:38 EST



On 3/5/24 8:14 AM, Andy Shevchenko wrote:
> intel-mid.h is providing some core parts of the South Complex PM,
> which are usually are not used by individual drivers. In particular,
> this driver doesn't use it, so simply remove the unused header.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
Looks fine to me.

Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx>
> drivers/platform/x86/intel_scu_pcidrv.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel_scu_pcidrv.c b/drivers/platform/x86/intel_scu_pcidrv.c
> index d904fad499aa..dbf0310448da 100644
> --- a/drivers/platform/x86/intel_scu_pcidrv.c
> +++ b/drivers/platform/x86/intel_scu_pcidrv.c
> @@ -11,7 +11,6 @@
> #include <linux/init.h>
> #include <linux/pci.h>
>
> -#include <asm/intel-mid.h>
> #include <asm/intel_scu_ipc.h>
>
> static int intel_scu_pci_probe(struct pci_dev *pdev,

--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer