Re: [PATCH v1 1/2] platform/x86: intel_scu_wdt: Remove unused intel-mid.h

From: Kuppuswamy Sathyanarayanan
Date: Tue Mar 05 2024 - 14:37:38 EST



On 3/5/24 8:14 AM, Andy Shevchenko wrote:
> intel-mid.h is providing some core parts of the South Complex PM,
> which are usually are not used by individual drivers. In particular,
> this driver doesn't use it, so simply remove the unused header.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---

Looks good to me.

Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx>

> drivers/platform/x86/intel_scu_wdt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel_scu_wdt.c b/drivers/platform/x86/intel_scu_wdt.c
> index c2479777a1d6..a5031a25632e 100644
> --- a/drivers/platform/x86/intel_scu_wdt.c
> +++ b/drivers/platform/x86/intel_scu_wdt.c
> @@ -13,7 +13,6 @@
>
> #include <asm/cpu_device_id.h>
> #include <asm/intel-family.h>
> -#include <asm/intel-mid.h>
> #include <asm/io_apic.h>
> #include <asm/hw_irq.h>
>

--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer