Re: [PATCH] ssb: Fix potential NULL pointer dereference in ssb_device_uevent

[Kalle Valo]

Rand Deeb <rand.sec96@xxxxxxxxx> wrote:

> The ssb_device_uevent function first attempts to convert the 'dev' pointer
> to 'struct ssb_device *'. However, it mistakenly dereferences 'dev' before
> performing the NULL check, potentially leading to a NULL pointer
> dereference if 'dev' is NULL.
> 
> To fix this issue, this patch moves the NULL check before dereferencing the
> 'dev' pointer, ensuring that the pointer is valid before attempting to use
> it.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Signed-off-by: Rand Deeb <rand.sec96@xxxxxxxxx>
> Acked-by: Michael Büsch <m@xxxxxxx>

Failed to apply:

error: sha1 information is lacking or useless (drivers/ssb/main.c).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Applying: ssb: Fix potential NULL pointer dereference in ssb_device_uevent
Patch failed at 0001 ssb: Fix potential NULL pointer dereference in ssb_device_uevent

Patch set to Changes Requested.

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20240229093756.129324-1-rand.sec96@xxxxxxxxx/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches