Re: [PATCH v1 2/3] watchdog: intel-mid_wdt: Don't use "proxy" headers

[Guenter Roeck]

On Tue, Mar 05, 2024 at 06:52:19PM +0200, Andy Shevchenko wrote:
> Update header inclusions to follow IWYU (Include What You Use)
> principle.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

> ---
>  drivers/watchdog/intel-mid_wdt.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/intel-mid_wdt.c b/drivers/watchdog/intel-mid_wdt.c
> index b41c45582aa4..06d5d207a065 100644
> --- a/drivers/watchdog/intel-mid_wdt.c
> +++ b/drivers/watchdog/intel-mid_wdt.c
> @@ -9,11 +9,17 @@
>   *      Contact: David Cohen <david.a.cohen@xxxxxxxxxxxxxxx>
>   */
>  
> +#include <linux/bitops.h>
> +#include <linux/device.h>
> +#include <linux/errno.h>
>  #include <linux/interrupt.h>
> +#include <linux/math.h>
>  #include <linux/module.h>
> -#include <linux/nmi.h>
> +#include <linux/panic.h>
>  #include <linux/platform_device.h>
> +#include <linux/types.h>
>  #include <linux/watchdog.h>
> +
>  #include <linux/platform_data/intel-mid_wdt.h>
>  
>  #include <asm/intel_scu_ipc.h>
> -- 
> 2.43.0.rc1.1.gbec44491f096
>