Re: [PATCH 2/2] staging: vme_user: Add a newline after variable declarations

[Jonathan Bergh]

On Tue, Mar 05, 2024 at 02:13:23PM +0000, Greg KH wrote:
> On Sun, Mar 03, 2024 at 11:05:47AM +0100, Jonathan Bergh wrote:
> > This patch makes the following change:
> >  * Adds a newline after the variable declarations as per checkpatch's
> >    warning
> > 
> > Signed-off-by: Jonathan Bergh <bergh.jonathan@xxxxxxxxx>
> > ---
> >  drivers/staging/vme_user/vme_tsi148.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/staging/vme_user/vme_tsi148.h b/drivers/staging/vme_user/vme_tsi148.h
> > index 2a92497c5570..a1b8288b101a 100644
> > --- a/drivers/staging/vme_user/vme_tsi148.h
> > +++ b/drivers/staging/vme_user/vme_tsi148.h
> > @@ -34,6 +34,7 @@ struct tsi148_driver {
> >  	void __iomem *base;	/* Base Address of device registers */
> >  	wait_queue_head_t dma_queue[2];
> >  	wait_queue_head_t iack_queue;
> > +
> >  	void (*lm_callback[4])(void *);	/* Called in interrupt handler */
> >  	void *lm_data[4];
> >  	void *crcsr_kernel;
> 
> Please always look at the change to see if checkpatch is correct or not
> (hint, for this one, it is not.)  Also see the archives for many people
> who have done the same thing in the past :)

Got it, thanks for that. 

> 
> thanks,
> 
> greg k-h