Re: [PATCH net-next v9 08/13] ptp: Add phc source and helpers to register specific PTP clock or get information

From: Jakub Kicinski
Date: Tue Mar 05 2024 - 11:39:53 EST


On Tue, 5 Mar 2024 16:35:46 +0100 Köry Maincent wrote:
> > Still, wouldn't it be simpler to store all accessible PTP instances
> > in the netdev?
>
> You are talking about something like the phy topology but for the ptp?
>
> Then when asking information on a PHC (tsinfo or hwtstamp config) from ethtool
> we would have to look at the PHC topology of the netdev. This could work. Not
> sure it is much simpler, do you see other advantages that it could have?

I was thinking just an array indexed by enum hwtstamp_source.
But you're right, once we can express more than one phy per
netdev we're basically back to doing similar walks. Fair.