Re: [PATCH 5/6] scsi: mvsas: Use LIBSAS_SHT_BASE

[John Garry]

On 05/03/2024 13:47, Jason Yan wrote:
> > > Doesn't hvae ->eh_abort_handler too.
> >
> > Is setting eh_abort_handler actually really ever required for libsas 
> > drivers? We have sas_eh_abort_handler, so I assume so..
>
> For now among libsas drivers only isci has eh_abort_handler. But 
> LIBSAS_SHT_BASE is setting it by default. I think it's better to keep 
> the same as before for other four drivers.

Sure, but I do wonder why it is required for isci, if at all - I'll check.

The motivation to not require it is a smaller and consistent API used by 
all the libsas drivers.

Thanks,
John