Re: [PATCH] serial: 8250_pnp: Support configurable reg shift property

From: Greg KH
Date: Tue Mar 05 2024 - 06:14:11 EST


On Tue, Mar 05, 2024 at 11:24:08AM +0800, GuanBing Huang wrote:
> 在 2024/3/1 6:00, Greg KH 写道:
>
> > On Thu, Feb 29, 2024 at 07:51:54PM +0800, GuanBing Huang wrote:
> > > From: albanhuang <albanhuang@xxxxxxxxxxx>
> > >
> > > The 16550a serial port based on the ACPI table requires obtaining the
> > > reg-shift attribute. In the ACPI scenario, If the reg-shift property
> > > is not configured like in DTS, the 16550a serial driver cannot read or
> > > write controller registers properly during initialization.
> > >
> > > Signed-off-by: albanhuang <albanhuang@xxxxxxxxxxx>
> > > Signed-off-by: tombinfan <tombinfan@xxxxxxxxxxx>
> > > Signed-off-by: dylanlhdu <dylanlhdu@xxxxxxxxxxx>
> > "interesting" names, can you not just use your native encoding to make
> > this easier?
>
> > ->I'm sorry,this is my first time sending a patch.The names should be changed to the following. Do I need to resend a new patch?
>
> Signed-off-by: Guanbing Huang <albanhuang@xxxxxxxxxxx>
> Signed-off-by: Bing Fan <tombinfan@xxxxxxxxxxx>
> Signed-off-by: Linheng Du <dylanlhdu@xxxxxxxxxxx>

Yes please, I can not take it in the original format.

thanks,

greg k-h