Re: [PATCH net-next v9 02/13] net: Make dev_get_hwtstamp_phylib accessible

[Köry Maincent]

On Tue, 5 Mar 2024 10:56:27 +0100
Köry Maincent <kory.maincent@xxxxxxxxxxx> wrote:

> > > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> > > index f07c8374f29c..7f78aef73fe1 100644
> > > --- a/include/linux/netdevice.h
> > > +++ b/include/linux/netdevice.h
> > > @@ -4005,6 +4005,8 @@ int generic_hwtstamp_set_lower(struct net_device
> > > *dev, int dev_set_hwtstamp_phylib(struct net_device *dev,
> > >  			    struct kernel_hwtstamp_config *cfg,
> > >  			    struct netlink_ext_ack *extack);
> > > +int dev_get_hwtstamp_phylib(struct net_device *dev,
> > > +			    struct kernel_hwtstamp_config *cfg);    
> > 
> > since we don't expect modules to call this, how about we move dev_set*
> > and the new declaration to net/core/dev.h ?  
> 
> Ok for me.

I replied to quickly.
It seems this header in not include in ethtool part. 
This would imply adding #include "../core/dev.h" in the tsinfo.c file.
Not sure this is what we want.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com