Re: [PATCH net-next v9 07/13] ptp: Move from simple ida to xarray

From: Jakub Kicinski
Date: Mon Mar 04 2024 - 21:48:05 EST


On Mon, 26 Feb 2024 14:39:58 +0100 Kory Maincent wrote:
> +static DEFINE_XARRAY_FLAGS(ptp_clocks_map, XA_FLAGS_LOCK_IRQ | XA_FLAGS_ALLOC);

Why _IRQ? anything on the fastpath hopefully has a pointer to the clock
already, I'd hope. And we often reserve ID 0 as invalid.

IOW DEFINE_XARRAY_ALLOC1() ?

BTW could be a standalone patch, Xarray conversion from IDA is an
improvement in itself.