Re: [PATCH v5 2/7] scsi: libsas: Define NCQ Priority sysfs attributes for SATA devices

From: Jason Yan
Date: Mon Mar 04 2024 - 21:45:02 EST


On 2024/3/5 8:50, Igor Pylypiv wrote:
Libata sysfs attributes cannot be used for libsas managed SATA devices
because the ata_port location is different for libsas.

Defined sysfs attributes (visible for SATA devices only):
- /sys/block/sda/device/ncq_prio_enable
- /sys/block/sda/device/ncq_prio_supported

The newly defined attributes will pass the correct ata_port to libata
helper functions.

Reviewed-by: John Garry<john.g.garry@xxxxxxxxxx>
Reviewed-by: Damien Le Moal<dlemoal@xxxxxxxxxx>
Signed-off-by: Igor Pylypiv<ipylypiv@xxxxxxxxxx>
---
drivers/scsi/libsas/sas_ata.c | 94 +++++++++++++++++++++++++++++++++++
include/scsi/sas_ata.h | 6 +++
2 files changed, 100 insertions(+)

Reviewed-by: Jason Yan <yanaijie@xxxxxxxxxx>