Re: [PATCH v4 2/2] pwm: sophgo: add pwm support for Sophgo CV1800 SoC

[Jingbao Qiu]

On Mon, Mar 4, 2024 at 11:02 PM Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:
>
> On 04/03/2024 14:40, Jingbao Qiu wrote:
> > On Mon, Mar 4, 2024 at 6:15 PM Krzysztof Kozlowski
> > <krzysztof.kozlowski@xxxxxxxxxx> wrote:
> >>
> >> On 04/03/2024 10:02, Jingbao Qiu wrote:
> >>> Implement the PWM driver for CV1800.
> >>>
> >>> Signed-off-by: Jingbao Qiu <qiujingbao.dlmu@xxxxxxxxx>
> >>
> >> ...
> >>
> >>> +
> >>> +     ret = devm_add_action_or_reset(&pdev->dev, devm_clk_rate_exclusive_put,
> >>> +                                    priv->clk);
> >>> +     if (ret) {
> >>> +             clk_rate_exclusive_put(priv->clk);
> >>> +             return ret;
> >>
> >> Please test this path - you have double put.
> >>
> >
> > Thank you for your reply. You're right. If the
> > devm_add_action_or_reset()  function
> > fails to add an action, it will call the action.
> >
> > By the way, if I need to resend the patch, should I wait for the
> > maintainer to review it, or
> > should I immediately correct this error and resend it.
>
> I recommend one patchset per day.
>

Thank you for your suggestion.

Best regards,
Jingbao Qiu