Re: [PATCH v4 1/2] x86/resctrl: Pass domain to target CPU

[Reinette Chatre]

Hi Tony,

On 3/4/2024 4:17 PM, Luck, Tony wrote:
>>> +                   cpu = cpumask_any(&d->cpu_mask);
>>>
>>
>> cpu only needs to be assigned once. How about initializing cpu to
>> nr_cpu_ids at the same time msr_param.res and msr_param.dom is
>> initialized and only assign it when msr_param.res is assigned?
>> I think that will be more robust.
>>
>> If you agree and do this then please feel free to add:
>> Reviewed-by: Reinette Chatre <reinette.chatre@xxxxxxxxx>
> 
> Reinette,
> 
> I agree. I'll move the assignment to "cpu" outside the CDP_NUM_TYPES
> loop.
> 

If I understand correctly that would always look for a valid "cpu"
even when none is needed. Not quite what I proposed but should
work. Just some wasted cycles in a non critical path. 

Reinette