Re: [PATCH] tracing: Remove precision vsnprintf() check from print event

From: Steven Rostedt
Date: Mon Mar 04 2024 - 19:16:28 EST


On Mon, 4 Mar 2024 18:55:00 -0500
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> On Mon, 4 Mar 2024 18:23:41 -0500
> Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx> wrote:
>
> > It appears to currently be limited by
> >
> > #define TRACE_SEQ_BUFFER_SIZE (PAGE_SIZE * 2 - \
> > (sizeof(struct seq_buf) + sizeof(size_t) + sizeof(int)))
> >
> > checked within tracing_mark_write().
>
> Yeah, I can hard code this to 8K as it handles output of complete events,
> that can dump a lot of data, and then limit the trace_marker writes to be 4K.

Actually, the trace_marker writes is already limited by
TRACE_SEQ_BUFFER_SIZE, and by making this hard coded to 8K, it limits the
size of the trace_marker writes.

I may make the writes even smaller.

-- Steve