Re: [PATCH 3/4] xattr: Use dedicated slab buckets for setxattr()

From: Kees Cook
Date: Mon Mar 04 2024 - 18:03:30 EST


On Mon, Mar 04, 2024 at 02:16:48PM -0800, Eric Biggers wrote:
> On Mon, Mar 04, 2024 at 10:49:31AM -0800, Kees Cook wrote:
> > xattr: Use dedicated slab buckets for setxattr()
>
> This patch actually changes listxattr(), not setxattr().
>
> getxattr(), setxattr(), and listxattr() all allocate a user controlled size.
> Perhaps you meant to change all three? What is special about listxattr() (or
> setxattr() if you actually meant to change that one)?

Whoops. Yes, I did one and stopped. :P I'll fix it up in v2.

--
Kees Cook