Re: [PATCH v2 0/3] panel-simple: add support for Crystal Clear CMT430B19N00

From: Rob Herring
Date: Mon Mar 04 2024 - 16:25:49 EST


On Mon, Mar 04, 2024 at 07:29:04PM +0000, Conor Dooley wrote:
> On Mon, Mar 04, 2024 at 05:04:51PM +0100, Jérémie Dautheribes wrote:
> > Hello everyone,
> >
> > This patch series add support for the Crystal Clear Technology
> > CMT430B19N00 4.3" 480x272 TFT-LCD panel.
> > It also adds Crystal Clear Technology to vendor-prefixes.yaml.
> >
> > Please note that unfortunately there is no public datasheet available
> > for this panel.
> >
> > Changes in v2:
> > - add link to the Crystal Clear Technology website in commit message, as
> > suggested by Conor Dooley and Neil Armstrong.
>
> You forgot however to add the acks that I gave you for the two
> dt-binding patches.

I was wondering why my scripts said this was already reviewed with that
missing. Turns out b4 will now check prior versions and add the tags as
long as the patch-id matches. Neat, but the submitter really has to
grasp how that all works (knowing if the patch-id changed) as well as
the maintainer has to use b4, so we can't really rely on it.

Here's b4 debug log:

new message: 20240223-subtotal-aground-268d135adeff@spud
Running git --no-pager patch-id --stable
found matching patch-id for Re: [PATCH 2/3] dt-bindings: display: simple: add support for Crystal Clear CMT430B19N00
new message: 20240229-woven-lively-1d90687b2d03@spud
skipping reply without trailers: 20240229-woven-lively-1d90687b2d03@spud
new message: 20240223134517.728568-2-jeremie.dautheribes@xxxxxxxxxxx
skipping non-reply: 20240223134517.728568-2-jeremie.dautheribes@xxxxxxxxxxx
Analyzing follow-up: Re: [PATCH v2 0/3] panel-simple: add support for Crystal Clear CMT430B19N00 (conor@xxxxxxxxxx)
no trailers found, skipping
Analyzing follow-up: Re: [PATCH v2 3/3] drm/panel: simple: add CMT430B19N00 LCD panel support (mripard@xxxxxxxxxx)
no trailers found, skipping
adding "Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>" from trailer_map to: [PATCH v2 1/3] dt-bindings: Add Crystal C
lear Technology vendor prefix
adding "Link: http://www.cct.com.my/"; from trailer_map to: [PATCH v2 1/3] dt-bindings: Add Crystal Clear Technology vendor
prefix
adding "Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>" from trailer_map to: [PATCH v2 2/3] dt-bindings: display: simp
le: add support for Crystal Clear CMT430B19N00
adding "Reviewed-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>" from trailer_map to: [PATCH v2 3/3] drm/panel: simple: add
CMT430B19N00 LCD panel support
adding "Reviewed-by: Jessica Zhang <quic_jesszhan@xxxxxxxxxxx>" from trailer_map to: [PATCH v2 3/3] drm/panel: simple: add
CMT430B19N00 LCD panel support