Re: [PATCH v3 2/2] riscv: Fix text patching when IPI are used

From: Björn Töpel
Date: Mon Mar 04 2024 - 15:24:19 EST


Conor Dooley <conor@xxxxxxxxxx> writes:

> On Thu, Feb 29, 2024 at 01:10:56PM +0100, Alexandre Ghiti wrote:
>> For now, we use stop_machine() to patch the text and when we use IPIs for
>> remote icache flushes (which is emitted in patch_text_nosync()), the system
>> hangs.
>>
>> So instead, make sure every CPU executes the stop_machine() patching
>> function and emit a local icache flush there.
>>
>> Co-developed-by: Björn Töpel <bjorn@xxxxxxxxxxxx>
>> Signed-off-by: Björn Töpel <bjorn@xxxxxxxxxxxx>
>> Signed-off-by: Alexandre Ghiti <alexghiti@xxxxxxxxxxxx>
>> Reviewed-by: Andrea Parri <parri.andrea@xxxxxxxxx>
>
> What commit does this fix?

Hmm. The bug is exposed when the AIA IPI are introduced, and used
(instead of the firmware-based).

I'm not sure this is something we'd like backported, but rather a
prerequisite to AIA.

@Anup @Alex WDYT?