Re: [PATCH] ptp: fc3: Convert to platform remove callback returning void

From: Simon Horman
Date: Mon Mar 04 2024 - 14:30:01 EST


On Mon, Mar 04, 2024 at 10:13:25AM +0100, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> ---
> Hello,
>
> note this driver is currently only available in next.

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>