Re: [PATCH] gpio: swnode: Don't use __free() on result of swnode_get_gpio_device()

From: Bartosz Golaszewski
Date: Mon Mar 04 2024 - 11:34:53 EST


On Mon, Mar 4, 2024 at 5:03 PM Charles Keepax
<ckeepax@xxxxxxxxxxxxxxxxxxxxx> wrote:
>
> swnode_get_gpio_device() can return an error pointer, however
> gpio_device_put() is not able to accept error values. Thus using
> __free() will result in dereferencing an invalid pointer.
>

Can you post the steps to reproduce this? Because it should work[1].

Bart

[1] https://elixir.bootlin.com/linux/latest/source/include/linux/gpio/driver.h#L616