Re: [PATCH] i2c: exynos5: Init data before registering interrupt handler

From: Jesper Nilsson
Date: Mon Mar 04 2024 - 11:18:44 EST


On Mon, Mar 04, 2024 at 04:08:00PM +0100, Krzysztof Kozlowski wrote:
> On 04/03/2024 16:04, Andi Shyti wrote:
> >> -
> >> i2c->variant = of_device_get_match_data(&pdev->dev);
> >> + if (!i2c->variant) {
> >> + dev_err(&pdev->dev, "can't match device variant\n");
> >> + return -ENODEV;
> >
> > return dev_err_probe(), please.
>
> How this condition even possibly happen? And how is this related to the
> problem described here?

No, it was not. That was part of the debugging before we understood
the real problem.

> No, don't mix two different issues.

No problem, I can drop this part.

> Best regards,
> Krzysztof

/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@xxxxxxxx